How can I contribute?
There are many ways to contribute to an open-source project. From liking a tweet to show some interest to solving a heavy handed coding problem.
The most obvious thing where we can use some help is fixing bugs, but there are a lot of other things that most certainly would be welcome.
Bug fixes
The most welcome additions to the project are bug fixes. The philosophy behind this is that everyone should be able to fix their own bug. If we can achieve this as a community, we can share the workload and all benefit together. The project can move at a faster pace and improve as a whole.
We strongly encourage people to embrace the reward of solving their own problems. We'll ask for a regression test when you fix a bug, to guarantee that you won't encounter the bug again.
bug (soundness)
Our goal is for Fantomas to be able to format all files out of the box without breaking correctness.
It's very important to us that a new user's experience is smooth and at the very least results in correct code.
Bugs labelled bug (soundness)
all indicate places where a new user might bounce off Fantomas because it actually broke their code.
We want to make sure users get a chance to explore the settings and tweak the style.
If you can help us out by fixing a soundness bug, you can really help the project move forward.
bug (stylistic)
Besides breaking correctness another kind of bug is that the style of the output might not be what you expect.
Bugs like this are labelled as bug (stylistic)
.
This includes cases where Fantomas breaks one of its own formatting rules or fails to respect one of its settings.
Again, here: scratch your own itch. If something bothers you, the best cure is to try a take a stab at it yourself.
Good first issues
If you wish to solve an issue, but don't know where to start, you can take a look that good first issue list.
These issues are typically easier to pick up and might only require a few small changes to solve them.
In case you want to solve any issue and would like some more guidance to start, you can also just ask this on the GitHub issue. The maintainer can give you additional pointers to get you on your way.
Adoption
The dream is that every F# developer can use Fantomas at any time. This aspiration is an odyssey that might never be complete, but any step in that direction is most welcome. Try introducing automatic formatting in your project, at work, or in an open-source project. This tool will only improve by adoption.
fsprojects
As Fantomas is part of the F# Community Project Incubation Space, it would be nice to see all the sibling projects formatted as well.
We've put a lot of emphasis on continued formatting using the --check
flag. Having that CI setup in place really brings it home.
Big fish
For marketing purposes, it is also very interesting if a larger or well-known project is using Fantomas.
We can put these on our landing page and that really sends a strong message.
Any fish really
Regardless of size or type of project. Any project that checks Fantomas in their CI system is most welcome.
Sponsoring
Fantomas grew significantly as a result of its first sponsorship deal with G-Research.
It would still be in the dark ages if it weren't for this support. For that we will forever be grateful.
If you want to help increase adoption by providing financial support, you can reach out to sponsoring@fantomas.io.
Keeping the grass green
There are also some smaller deeds that can benefit the codebase.
Eliminate dead code
Here and there, there are parts of code that are no longer being used. Ranging from unused parameters to complete functions.
A PR that cleans up these things would be appreciated as well.
Linting
Using F# Lint or other editor tooling, sometimes small improvements can be detected. Redundant parenthesis for example.
Tweaks like this are nice.
Understand how things work
One other thing that changes your perception of code all together is knowing how Fantomas does what it does.
Having a sense of the inner workings of Fantomas can be beneficial in understanding how the output was achieved.
It broadens your horizon in general, as it touched a lot of interesting concepts, and you start looking differently at your F# code.
Your sentiment on what you think matters might change, once you realized the level of complexity it involves.
Documentation
Found a typo? Still confused about something? Do you have some knowledge that should totally be documented?
Let us know! We really value any contribution to our documentation. The more knowledge is here, the brighter the future of the project.
Please do no hesitate here 😊.
You can find some instructions on running the documentation locally in the .README.md file in the docs
folder.
The only prerequisite to run the docs, is having a recent local dotnet sdk.
New releases
Testing out new releases is also a huge way to help us. Spotting regressions early really helps to fix them early.
Move to the latest
Always try and stay on the latest version of Fantomas for your day-to-day projects.
Updating to the newer version that might only have a couple of fixes might seem insignificant, but it really helps.
Try alphas and betas
Please give an alpha a spin if you are interested in submitting feedback for new development.
Try both versions if you want to make sure everything still works for you.
Don't feel obliged to use an alpha/beta in your day-to-day flow, just try them to see if the potential next stable version will still work.
We have over 2000 unit tests, that still doesn't tell us if the next release will break your code or not.
Improve the Syntax Tree
Fantomas uses the parser from the F# compiler to construct the untyped syntax tree.
This tree is later used to reconstruct the code. The better the tree, the better Fantomas can operate on it.
The tree can be improved over at dotnet/fsharp when a valid use-case appears.
Trivia nodes
Trivia nodes in the syntax tree are nodes the compiler doesn't need to compile the code. However, for Fantomas they can be the missing link to perfectly restore the code.
For example, in issue #2360, the information about the and
keyword is missing in the syntax tree.
If this information was available in SynTypeDefnTrivia, the bug could be fixed.
Better representation
Sometimes the existing shape of the syntax tree doesn't quite cover the syntax perfectly.
For example, in issue #2264, the measure was represented as
Code:
[<Measure>] type herth = / second
Old AST:
Types
([SynTypeDefn
(SynComponentInfo
([{ Attributes = [ ... ], None, [], [herth],
PreXmlDoc ((1,0), FSharp.Compiler.Xml.XmlDocCollector),
false, None, tmp.fsx (1,17--1,22)),
Simple
(TypeAbbrev
(Ok,
Tuple
(false,
[(true,
StaticConstant (Int32 1, tmp.fsx (1,25--1,33)));
(false,
LongIdent (SynLongIdent ([second], [], [None])))], ...]
Notice StaticConstant (Int32 1, ...)
, the source code doesn't contain any 1
at all.
After dotnet/fsharp#13440,
New AST:
Types
([SynTypeDefn
(SynComponentInfo
([{ Attributes =
[{ TypeName = SynLongIdent ([Measure], [], [None])
ArgExpr = Const (Unit, tmp.fsx (1,2--1,9))
Target = None
AppliesToGetterAndSetter = false
Range = tmp.fsx (1,2--1,9) }]
Range = tmp.fsx (1,0--1,11) }], None, [], [herth],
PreXmlDoc ((1,0), FSharp.Compiler.Xml.XmlDocCollector),
false, None, tmp.fsx (1,17--1,22)),
Simple
(TypeAbbrev
(Ok,
Tuple
(false,
[Slash tmp.fsx (1,25--1,26);
Type
(LongIdent (SynLongIdent ([second], [], [None])))],
tmp.fsx (1,25--1,33)), tmp.fsx (1,25--1,33)), ... ]
This update to the tree made it very straightforward to fix the original bug in Fantomas.
Another example of code that could benefit from a better representation is extern.
type MeasureAttribute = inherit Attribute new: unit -> MeasureAttribute
--------------------
new: unit -> MeasureAttribute